-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Use IPAM solution for node ips #130
Comments
In the future, it would be good, if IONOS has it's on pool implementation to use IONOS IP Block directly. |
We'll need something like this, too. I'll collect some more information and get back to you later this week. |
I'm not sure about the I have doubts whether our general network design of having some fields related to the primary NIC only and Two things to keep in mind for the implementation, though:
|
**What is the purpose of this pull request/Why do we need it?** We would like to get IPs from a fixed pool of IPs instead of relying on the DHCP. **Issue #, if available:** #130 **Description of changes:** - added IPv4PoolRef/IPv6PoolRef to both IonosCloudMachine and Network - workflow: IonosCloudMachine controller checks for PoolRefs and creates IPAddressClaims when needed. It then waits for an external controller to create IPAddress objects from the IPAddressClaim. Then it uses the IP from the IPAddress object to create a server via Ionos cloud api. **Special notes for your reviewer:** I did not write tests yet as I am waiting for #137 to be merged and I'd like to get some feedback about this PR first. I am also unsure where I should put the docs, I did not find anything for the other api stuff beside the api definition itself. Maybe this is already enough? **Checklist:** - [ ] Documentation updated - [x] Unit Tests added - [ ] E2E Tests added - [x] Includes [emojis](https://github.com/kubernetes-sigs/kubebuilder-release-tools?tab=readme-ov-file#kubebuilder-project-versioning)
Describe the solution you'd like:
We are using third party systems outside of kubernetes which only accept incoming traffic from certain ip ranges.
Therefore we need static node ips.
CAPV for example allows to use an IPAM provider like https://github.com/kubernetes-sigs/cluster-api-ipam-provider-in-cluster
The proposal would be to add an optional reference to an IPAddressPools in the IonosCloudMachineSpec.
The IonosCloudMachineController would create an IPAddressClaim and wait for an IPAM provider to create an IPAddress from the IPAddressClaim. When the IPAddress is created it can request the ionos api to create the server with this IP.
If there is no reference we use DHCP just like before.
What do you think about the api change? If you agree I'd like to implement it.
The text was updated successfully, but these errors were encountered: