docs(installation/android.md): strengthen JDK8 requirement wording #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to match breaking changes
… iOS debug process (ionic-team#226)
Several mentions of a non-existent about page, but it is no longer (assuming this is from v3?) called that, its tab2. The references are confusing but then the snippet suggesting the code `<ion-tab-button tab="about">` actually breaks the app.
constructor example is missing the closing curly brace.
fix(first-app-v4): missing curly brace
fix(first-app-v4): about page refs - fixes ionic-team#242
It's not just recommended, it's required. I tried this today and there is a flat out version check in the source code that locks it to JDK8. Also, added https to the download link as the site runs on that now.
rtpHarry
changed the title
|
FYI if you don't have much time to research this then here is some help: I also worked with the cordova-android team to clarify this in their error messages and it's been accepted:
If you look in the files changed the version check is just around those changed lines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not just recommended, it's required. I tried this today and there is a flat out version check in the source code that locks it to JDK8.
Also, added https to the download link as the site runs on that now.