Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(first-app-v4): missing curly brace #247

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

rtpHarry
Copy link
Contributor

Short description of what this resolves:

constructor example is missing the closing curly brace.

Changes proposed in this pull request:

Fixes: #

constructor example is missing the closing curly brace.
@rtpHarry rtpHarry changed the title v4 getting started guide - missing curly brace fix(first-app-v4): missing curly brace Dec 29, 2018
@camwiegert camwiegert requested a review from dotNetkow January 2, 2019 20:00
Copy link
Contributor

@dotNetkow dotNetkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! Thanks for the PR.

@dotNetkow dotNetkow merged commit c273c4e into ionic-team:master Jan 2, 2019
@rtpHarry rtpHarry deleted the patch-2 branch January 3, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants