feat(google-maps): Add getMapType method #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
requested review from
IT-MikeS,
ItsChaceD,
giralte-ionic and
theproducer
IT-MikeS
approved these changes
Feb 20, 2023
giralte-ionic
approved these changes
Feb 20, 2023
This comment was marked as abuse.
This comment was marked as abuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've called it
getMapTypeinstead of the proposedgetMapTypeId(google maps js SDK name) since we have asetMapTypefunction and the native methods in google maps SDK are calledgetMapType.Also returns our existing
MapTypeinstead of the proposedgoogle.maps.MapTypeIdsince they don't match.closes #1347