Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add - googleMaps : getMapTypeId #1347

Closed
rbalet opened this issue Dec 26, 2022 · 2 comments · Fixed by #1420
Closed

add - googleMaps : getMapTypeId #1347

rbalet opened this issue Dec 26, 2022 · 2 comments · Fixed by #1420
Labels
type: feature request A new feature, enhancement, or improvement

Comments

@rbalet
Copy link

rbalet commented Dec 26, 2022

Feature Request

Plugin

google-maps

Description

Add the google getMapTypeId() method to this library

@ionitron-bot ionitron-bot bot added the triage label Dec 26, 2022
@rbalet
Copy link
Author

rbalet commented Dec 26, 2022

I've open other issues and would be glad to do some pr, but I'm not sure I understand how exactly the CapacitorGoogleMaps.

Can I just simply add Same logics as the @angular/google-maps library or do I need to take care of something else ?

Here for example I would have added the following code inside the map.ts file

  /**
   * See
   * https://developers.google.com/maps/documentation/javascript/reference/map#Map.getMapTypeId
   */
  getMapTypeId(): google.maps.MapTypeId | string | undefined {
    return CapacitorGoogleMaps.getMapTypeId();
  }

and then this, inside the impkementation.ts file.

export interface CapacitorGoogleMapsPlugin extends Plugin {
// ...
getMapTypeId(): google.maps.MapTypeId | string | undefined
}

But then I do not understand why this is working as is..

@IT-MikeS IT-MikeS added the type: feature request A new feature, enhancement, or improvement label Jan 5, 2023
@ionitron-bot ionitron-bot bot removed the triage label Jan 5, 2023
@ionitron-bot
Copy link

ionitron-bot bot commented Mar 24, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the plugin, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature request A new feature, enhancement, or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants