fix(ios): Keyboard - Check if UIApplicationDelegate responds to window selector before calling it #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before calling it.
Steven0351
changed the title
Steven0351
requested review from
jcesarmobile,
theproducer,
ItsChaceD,
IT-MikeS and
giralte-ionic
giralte-ionic
approved these changes
Jun 10, 2022
IT-MikeS
approved these changes
Jun 10, 2022
jcesarmobile
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Keyboard plugin, a crash is occurring on iOS 15 when attempting to access a window property that doesn't exist:
This PR adds a check make sure
UIApplicationDelegateresponds to the window selector before attempting to access it.