-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(analytics): remove ad_impression from reserved events #6312
fix(analytics): remove ad_impression from reserved events #6312
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice - thank you! Even for small things we need the CLA signed but code wise, of course (since it is a simple change) it looks good...
Codecov Report
@@ Coverage Diff @@
## main #6312 +/- ##
=============================================
+ Coverage 53.42% 72.30% +18.88%
=============================================
Files 208 109 -99
Lines 10315 4649 -5666
Branches 1633 1046 -587
=============================================
- Hits 5510 3361 -2149
+ Misses 4547 1210 -3337
+ Partials 258 78 -180 |
CLA missing and lint needs some help. #6314 will implement this |
Description
Related issues
Fixes #6307
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter