ad_impression event needs to be removed from reserved events list

[alexpovkolas]

Issue

Currently ad_impression event is reserved so when an app tries to log it RNFirebase throws an exception.

But according to Google docs it is possible to track impression level manually for non-google monetization platforms

The following line needs to be removed

---

Project Files

Javascript

Click To Expand

package.json:

# N/A

firebase.json for react-native-firebase v6:

# N/A

iOS

Click To Expand

ios/Podfile:

• I'm not using Pods
• I'm using Pods and my Podfile looks like:

# N/A

AppDelegate.m:

// N/A

---

Android

Click To Expand

Have you converted to AndroidX?

• my application is an AndroidX application?
• I am using android/gradle.settings jetifier=true for Android compatibility?
• I am using the NPM package jetifier for react-native compatibility?

android/build.gradle:

// N/A

android/app/build.gradle:

// N/A

android/settings.gradle:

// N/A

MainApplication.java:

// N/A

AndroidManifest.xml:

<!-- N/A -->

---

Environment

Click To Expand

react-native info output:

 OUTPUT GOES HERE

• Platform that you're experiencing the issue on:
  • iOS
  • Android
  • iOS but have not tested behavior on Android
  • Android but have not tested behavior on iOS
  • Both
• react-native-firebase version you're using that has this issue:
  • e.g. 5.4.3
• Firebase module(s) you're using that has the issue:
  • e.g. Instance ID
• Are you using TypeScript?
  • Y/N & VERSION

---

• 👉 Check out React Native Firebase and Invertase on Twitter for updates on the library.

[mikehardy]

Interesting! We have a couple other carve-outs (items from the reserved list https://firebase.google.com/docs/reference/android/com/google/firebase/analytics/FirebaseAnalytics.Event) that we pass and despite being reserved, they do work for various reasons.

Can you verify for me that when you reach into node_modules and comment that line out, you are able to log things as you need according to the link you included? https://firebase.google.com/docs/analytics/measure-ad-revenue#unity_1

[alexpovkolas]

Yip It works. I have ad_impression events in a firebase console and "Publisher ad impressions
by Ad unit" report. It looks the same as automatically tracked events from AdMob

[mikehardy]

Fantastic - thanks for verifying - looks like we have another carve-out then :-)

I have quite a few react-native-firebase environments but each of them has a separate sizable chunk of work unpacked in them and in progress so it might be a little bit before I get to this.

If you want to cut that time down and get this changed+released now, you could do a PR that comments that out with a comment next to it saying "manual tracking on this reserved word is allowed #6307" as a helper for any curious future code explorers.

Otherwise I'll make the change it just might take a bit. Thanks!