Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support FilePathsBase AbstractPath types #57

Merged
merged 4 commits into from
Mar 25, 2020
Merged

Support FilePathsBase AbstractPath types #57

merged 4 commits into from
Mar 25, 2020

Conversation

nickrobinson251
Copy link
Contributor

nickrobinson251
nickrobinson251 commented Mar 24, 2020
View reviewed changes
rofinn
rofinn approved these changes Mar 24, 2020
View reviewed changes
nickrobinson251
nickrobinson251 commented Mar 24, 2020
View reviewed changes
@nickrobinson251
Pass test function to mktempdir
862a02c 
- Bit cleaner; makes sure tempdir gets cleaned up sooner
@codecov
Copy link

codecov bot commented Mar 24, 2020 •
edited
Loading

Codecov Report

Merging #57 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   96.15%   96.12%   -0.03%     
==========================================
  Files           6        6              
  Lines         156      155       -1     
==========================================
- Hits          150      149       -1     
  Misses          6        6
Impacted Files Coverage Δ
src/JLSO.jl 100.00% <ø> (ø)
src/file_io.jl 96.00% <100.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249fb66...862a02c. Read the comment docs.

@nickrobinson251 nickrobinson251 merged commit bb70c22 into master Mar 25, 2020
@nickrobinson251 nickrobinson251 deleted the npr/path-types branch March 25, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattBrzezinski mattBrzezinski mattBrzezinski approved these changes

@oxinabox oxinabox oxinabox approved these changes

@rofinn rofinn rofinn approved these changes

@mjram0s mjram0s mjram0s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for FilePathsBase.jl
5 participants
@nickrobinson251 @mattBrzezinski @oxinabox @rofinn @mjram0s