Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FilePathsBase.jl #56

Closed
mjram0s opened this issue Mar 19, 2020 · 0 comments · Fixed by #57
Closed

Add support for FilePathsBase.jl #56

mjram0s opened this issue Mar 19, 2020 · 0 comments · Fixed by #57

Comments

@mjram0s
Copy link
Member

mjram0s commented Mar 19, 2020

It would be useful to support the features of FilePathsBase.jl rather than requiring users to construct string paths.

julia> using FilePathsBase, JLSO

julia> x = p"foo"
p"foo"

julia> y = p"bar"
p"bar"

julia> p = x / y / "file.jlso"
p"foo/bar/file.jlso"

julia> JLSO.save(p, :baz=>1)
ERROR: MethodError: no method matching save(::PosixPath, ::Pair{Symbol,Int64})
Closest candidates are:
  save(::IO, ::Pair...; kwargs...) at /Users/maryjoramos/.julia/packages/JLSO/vWQhu/src/file_io.jl:76
  save(::IO, ::Any; kwargs...) at /Users/maryjoramos/.julia/packages/JLSO/vWQhu/src/file_io.jl:75
  save(::String, ::Any...; kwargs...) at /Users/maryjoramos/.julia/packages/JLSO/vWQhu/src/file_io.jl:77
Stacktrace:
 [1] top-level scope at REPL[26]:1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant