fix(npm): remove quote in commit message for standalone packages #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jBouyoud
force-pushed
the
fix-npm-version-commit-message
branch
from
81d9446 to
a4ae181
Compare
Codecov Report
@@ Coverage Diff @@
## main #2165 +/- ##
==========================================
- Coverage 80.31% 80.31% -0.01%
==========================================
Files 66 66
Lines 5420 5419 -1
Branches 1269 1269
==========================================
- Hits 4353 4352 -1
Misses 707 707
Partials 360 360
Continue to review full report at Codecov.
|
|
@hipstersmoothie Anything that I can do help merge this PR ? |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Using auto on a standalone npm package the node package upgrade commit message is :
"Bump version to: 1.1.0 [skip ci]"Switch back to a non quoted version.
Why
Really strange to get quote in a commit message (non conventionnal).
Seems an issue in command between lerna based (
npx lerna version...) , and pure npm package (npm ...)Todo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor