Skip to content

Commit

Permalink
fix(npm): remove quote in commit message for standalone packages
Browse files Browse the repository at this point in the history
  • Loading branch information
jBouyoud committed Mar 7, 2022
1 parent 8fd6684 commit 81d9446
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions plugins/npm/__tests__/npm.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ describe("publish", () => {
Auto.SEMVER.patch,
"--no-commit-hooks",
"-m",
"'\"Bump version to: %s [skip ci]\"'",
"'Bump version to: %s [skip ci]'",
"--loglevel",
"silly",
]);
Expand Down Expand Up @@ -582,7 +582,7 @@ describe("publish", () => {
Auto.SEMVER.patch,
"--no-commit-hooks",
"-m",
"'\"Bump version to: %s [skip ci]\"'",
"'Bump version to: %s [skip ci]'",
]);
});

Expand Down Expand Up @@ -842,7 +842,7 @@ describe("publish", () => {
"1.0.1",
"--no-commit-hooks",
"-m",
"'\"Bump version to: %s [skip ci]\"'",
"'Bump version to: %s [skip ci]'",
]);
});

Expand Down
8 changes: 4 additions & 4 deletions plugins/npm/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import setTokenOnCI, { getRegistry, DEFAULT_REGISTRY } from "./set-npm-token";
import { writeFile, isMonorepo, readFile, getLernaJson } from "./utils";

const { isCi } = envCi();
const VERSION_COMMIT_MESSAGE = `'"Bump version to: %s [skip ci]"'`;
const VERSION_COMMIT_MESSAGE = "'Bump version to: %s [skip ci]'";

/** Get the last published version for a npm package */
async function getPublishedVersion(name: string) {
Expand Down Expand Up @@ -276,8 +276,8 @@ const pluginOptions = t.partial({
legacyAuth: t.boolean,
/** Whether to add package information to monorepo changelogs */
monorepoChangelog: t.boolean,
/**
* Path used when publishing packages.
/**
* Path used when publishing packages.
* When used with npm this is equivalent to npm publish <publishFolder>
* When used with lerna this is equivalent to lerna publish --contents <publishFolder>
*/
Expand Down Expand Up @@ -1007,7 +1007,7 @@ export default class NPMPlugin implements IPlugin {
"-m",
isIndependent
? `'"Bump independent versions [skip ci]"'`
: VERSION_COMMIT_MESSAGE,
: `${VERSION_COMMIT_MESSAGE}`,
this.exact && "--exact",
...verboseArgs,
]);
Expand Down

0 comments on commit 81d9446

Please sign in to comment.