Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes button title to not be an ambiguous reference when binding #21

Merged
merged 1 commit into from
May 30, 2018
Merged

Fixes button title to not be an ambiguous reference when binding #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CardParts/src/Classes/Card Parts/CardPartButtonView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public class CardPartButtonView : UIButton, CardPartView {

extension Reactive where Base: CardPartButtonView {

public var title: Binder<String>{
public var buttonTitle: Binder<String>{
return Binder(self.base) { (buttonView, title) -> () in
buttonView.setTitle(title, for: .normal)
}
Expand Down
4 changes: 2 additions & 2 deletions Example/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ EXTERNAL SOURCES:
:path: "../"

SPEC CHECKSUMS:
CardParts: befa6e8247eb2b654f94f67dedc1f77094a0e0bc
CardParts: f7493a7e3b21c32c317db4ce9552aa5bc742d477
Differentiator: a87be69eba49ec4ab460c7671143ee3a9eececfd
RxCocoa: d88ba0f1f6abf040011a9eb4b539324fc426843a
RxDataSources: cb7c31e652a87ebb919da45f716bbb87b3765f6b
Expand All @@ -39,4 +39,4 @@ SPEC CHECKSUMS:

PODFILE CHECKSUM: 74676e2d5bea3356515810e198c6e14ce8817a1e

COCOAPODS: 1.5.2
COCOAPODS: 1.5.3
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ CardPartButtonView displays a single button.

CardPartButtonView exposes the following reactive properties that can be bound to view model properties:
```swift
var title: String?
var buttonTitle: String?
var isSelected: Bool?
var isHighlighted: Bool?
var contentHorizontalAlignment: UIControlContentHorizontalAlignment
Expand Down