Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes button title to not be an ambiguous reference when binding #21

Merged
merged 1 commit into from
May 30, 2018
Merged

Fixes button title to not be an ambiguous reference when binding #21

merged 1 commit into from
May 30, 2018

Conversation

dtumer
Copy link
Contributor

@dtumer dtumer commented May 30, 2018

See #20 for the details about this fix.

Allows for binding to title of a button without the ambiguous reference bug appearing in Xcode.

croossin
croossin approved these changes May 30, 2018
View reviewed changes
Copy link
Contributor

@croossin croossin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Makes me think we should .gitignore the Pods/ folder and the Podfile.lock in the example app. Ill open an issue.

@croossin croossin merged commit bc033fb into master May 30, 2018
@croossin croossin deleted the bug/fix-button-title branch May 30, 2018 22:09
@croossin croossin mentioned this pull request May 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@croossin croossin croossin approved these changes

Assignees

@croossin croossin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtumer @croossin