Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build with gtsam 4.3.0 #1033

Merged
merged 2 commits into from
May 14, 2023
Merged

Conversation

matlabbe
Copy link
Member

No description provided.

@matlabbe matlabbe linked an issue May 14, 2023 that may be closed by this pull request
@matlabbe matlabbe merged commit 682d547 into master May 14, 2023
@matlabbe matlabbe deleted the matlabbe/1000-make-failed-gtsam-issue branch May 14, 2023 20:14
@wakoko79
Copy link

wakoko79 commented Apr 2, 2024

@matlabbe cc17ebe breaks gtsam 4.3.0 support.
At line 704 of rtabmap/corelib/src/optimizer/OptimizerGTSAM.cpp : gtsam::Values::iterator is used, but it only accessible with gtsam 4.1.1

matlabbe added a commit that referenced this pull request Apr 2, 2024
@matlabbe
Copy link
Member Author

matlabbe commented Apr 2, 2024

Should be fixed in 063ca9c, thx for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make failed, gtsam issue
2 participants