Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include all theme in allowed overrides #1014

Merged
merged 1 commit into from
Feb 15, 2022
Merged

fix: include all theme in allowed overrides #1014

merged 1 commit into from
Feb 15, 2022

Conversation

dhhyi
Copy link
Collaborator

@dhhyi dhhyi commented Feb 15, 2022 •
edited
Loading

PR Type

[x] Bugfix

What Is the Current Behavior?

A change from 9b595d1 was lost in the tslint to eslint migration

What Is the New Behavior?

Included again

Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Other Information

AB#74359

@dhhyi dhhyi added bug Something isn't working community Community contributions labels Feb 15, 2022
@MaxKless MaxKless merged commit 302285f into develop Feb 15, 2022
@MaxKless MaxKless deleted the fix/include-all-theme-as-override branch February 15, 2022 13:41
@shauke shauke added this to the 2.1 milestone Feb 16, 2022
SGrueber pushed a commit that referenced this pull request May 19, 2022
@dhhyi @SGrueber
fix: include all theme in allowed overrides (#1014)
4e5ecdf
SGrueber pushed a commit that referenced this pull request May 19, 2022
Merged PR 1268: migrate poc_ salessolution project to pwa 2.1
ddfafe8 
Related work items: #315, #960, #974, #983, #1005, #1006, #1007, #1009, #1010, #1012, #1013, #1014, #1015, #1016, #1018, #1019, #1020, #1021, #1022, #1023, #1024, #1025, #1026, #1029, #1031, #1033, #1034, #1035, #1037, #1038, #1039, #1040, #1042, #1043, #1044, #1045, #1049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxKless MaxKless MaxKless approved these changes

Assignees
No one assigned
Labels
bug Something isn't working community Community contributions
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@dhhyi @MaxKless @shauke