refactor: formly cleanup #1006
Merged
refactor: formly cleanup #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
requested changes
Feb 11, 2022
src/app/pages/checkout-review/checkout-review/checkout-review.component.spec.ts
Outdated
Show resolved
Hide resolved
...ages/registration/registration-form-configuration/registration-form-configuration.service.ts
Outdated
Show resolved
Hide resolved
SGrueber
requested changes
Feb 15, 2022
| ], | ||
| exports: [FieldTooltipComponent, FormlyBaseModule, ValidationIconsComponent, ValidationMessageComponent], |
There was a problem hiding this comment.
ComponentsModule instead of the 3 components - it will be easier for projects to add further components
SGrueber
approved these changes
Feb 16, 2022
SGrueber
pushed a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
## What Is the Current Behavior?
Currently, the formly functionality has been written once and not comprehensibly cleaned up since.
Issue Number: Closes #
## What Is the New Behavior?
More documentation, removed registration-form-configuration service from root, way cleaner formly module structure.
## Does this PR Introduce a Breaking Change?
[ ] Yes
[ ] No
## Other Information
AB#74160