Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix merge author url issue #9530

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

deysandip301
Copy link
Contributor

Closes #9476

Fixed the issue that extra ' is added to the work URLs when authors are merged..

Technical

Testing

Screenshot

Stakeholders

@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Jul 8, 2024
Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

I'm having trouble testing it locally as well and the testing deploy is failing.
However, it looks right to me so I'm going to approve and let the staff give it a last check.

image

@cdrini
Copy link
Collaborator

cdrini commented Jul 9, 2024

Looks good to me; I'm not testing this one since it seems unlikely to cause issue. Thanks folks!

@cdrini cdrini merged commit 8be7e9d into internetarchive:master Jul 9, 2024
4 checks passed
@deysandip301 deysandip301 deleted the issue9476 branch July 9, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

author merge page adds extra ' to work links
3 participants