Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

author merge page adds extra ' to work links #9476

Closed
RayBB opened this issue Jun 24, 2024 · 5 comments · Fixed by #9530
Closed

author merge page adds extra ' to work links #9476

RayBB opened this issue Jun 24, 2024 · 5 comments · Fixed by #9530
Assignees
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Response Issues which require feedback from lead Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Jun 24, 2024

Problem

The links are like: https://openlibrary.org/works/OL12421933W' instead of https://openlibrary.org/works/OL12421933W

It doesn't have a practical effect since we redirect anyway but probably an easy fix for someone to do.

Evidence / Screenshot

image

Relevant URL(s)

https://openlibrary.org/authors/merge?key=OL2698508A&key=OL5477118A&key=OL6394233A&key=OL4800041A

Reproducing the bug

  1. Go to ...
  2. Do ...
  • Expected behavior:
  • Actual behavior:

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Notes from this Issue's Lead

Proposal & constraints

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@RayBB RayBB added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jun 24, 2024
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Jun 24, 2024
@deysandip301
Copy link
Contributor

Hey @RayBB I would like to work on this issue
can you please assign this issue to me ??

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Jul 6, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented Jul 8, 2024

@deysandip301 you are assigned. Good luck!

@RayBB RayBB removed the Needs: Response Issues which require feedback from lead label Jul 8, 2024
@deysandip301
Copy link
Contributor

Hey @RayBB I think I got the problem which was causing the issue
it is due to an typo in the openlibrary/templates/merge/authors.html file (line number 95)
I fixed the problem but I am unable to test it in my own local machine as there are not such testcase in which I can test
Is there any other way to test that is it working fine or not ??

Screenshot from 2024-07-08 22-07-31

@RayBB
Copy link
Collaborator Author

RayBB commented Jul 8, 2024

@deysandip301 please open a PR and it can be tested from there 👍

@deysandip301
Copy link
Contributor

Hey @RayBB I have raised the PR please test is this working or not
and feel free to give any feedback....

@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Jul 8, 2024
@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Response Issues which require feedback from lead Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants