Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge tabs on author edit page #9305

Merged
merged 5 commits into from
May 28, 2024
Merged

merge tabs on author edit page #9305

merged 5 commits into from
May 28, 2024

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented May 20, 2024 •
edited
Loading

Closes #9280

Technical

I can fix the indentation in a later commit if needed. For now, just want to show how simple the change is.

Testing

Exits work fine. UI looks only slightly different. The page could use some general improvements but that's for another pr ;)

Screenshot

Before After
image image

Stakeholders

@RayBB RayBB added the Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] label May 20, 2024
@RayBB RayBB mentioned this pull request May 20, 2024
Closed
cdrini
cdrini requested changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Code looks good, could we try to make it look a little more like our work edit page? The style looks a little odd as is.

image

I think we just need to wrap it in a <fieldset class="major"> with a <legend> and it should look about the same.

@cdrini cdrini added Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] and removed Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] labels May 22, 2024
@github-actions github-actions bot removed the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label May 22, 2024
@RayBB RayBB added the Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] label May 22, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented May 22, 2024

@cdrini I edited it as you requested. It is better but doesn't exactly match well.
To avoid scope creep maybe we should just decide how to make links look and then open a different ticket for generally cleaning up the spacing/format of the author edit page.
image

@RayBB RayBB requested a review from cdrini May 22, 2024 20:38
@mekarpeles mekarpeles assigned jimchamp and cdrini and unassigned jimchamp May 23, 2024
cdrini
cdrini reviewed May 28, 2024
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! We can of course make changes to it later, but I also want to make sure it looks a little more visually consistent with the rest of the site; that's in scope 👍 Otherwise we're just trading one UI problem for another!

@cdrini
Copy link
Collaborator

cdrini commented May 28, 2024

Looking good!
image

@cdrini cdrini merged commit 0972686 into master May 28, 2024
5 checks passed
@cdrini cdrini deleted the move-author-edit-tab branch May 28, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini approved these changes

Assignees

@cdrini cdrini

Labels
Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we get rid of tabs on the author edit page?
3 participants
@RayBB @cdrini @jimchamp