Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we get rid of tabs on the author edit page? #9280

Closed
RayBB opened this issue May 16, 2024 · 3 comments · Fixed by #9305
Closed

Can we get rid of tabs on the author edit page? #9280

RayBB opened this issue May 16, 2024 · 3 comments · Fixed by #9305
Assignees
@RayBB
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented May 16, 2024

Problem

A clear and concise description of what you want to happen

I want to get rid of the "Links" tab (move the content on to the main tab)

Why?
Because it makes the author edit page jump around a bunch.
I don't think it really is all that useful to have it on a separate tab.
It will simplify our code.
Make one less dependency on the jquery tabs

Expected behaviour / screenshots (ex: Figma design screenshots for UI feature)

It'll be faster and simpler.

Additional Context

Example of the slow jumping:
https://github.com/internetarchive/openlibrary/assets/921217/2dc9c90f-203f-4e04-89c1-1deafa8b40f3

Proposal & Constraints

What is the proposed solution / implementation?

Move the links section down under the identifiers.
Remove the tabs stuff.
Will need to remove tabsAddauthor from index.js as well.

Is there a precedent of this approach succeeding elsewhere?

No

Which suggestions or requirements should be considered for how feature needs to appear or be implemented?

Leads

Related files

Stakeholders
@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels May 16, 2024
@mekarpeles
Copy link
Member

Merge 'em

@mekarpeles mekarpeles added Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Good First Issue Easy issue. Good for newcomers. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels May 20, 2024
@mekarpeles
Copy link
Member

@RayBB I may have put the cart before the horse here re: good first issue, feel free to mark it as such if you think it is!

@mekarpeles mekarpeles removed the Good First Issue Easy issue. Good for newcomers. [managed] label May 20, 2024
@RayBB RayBB mentioned this issue May 20, 2024
Merged
@RayBB RayBB self-assigned this May 20, 2024
@RayBB RayBB added the Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] label May 20, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented May 20, 2024

Opened a PR here #9305

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label May 21, 2024
@RayBB RayBB added Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. and removed Needs: Response Issues which require feedback from lead labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RayBB RayBB

Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

merge tabs on author edit page internetarchive/openlibrary
2 participants
@RayBB @mekarpeles