Partially fix static images not working in gitpod

[cdrini]

Technical

Testing

Screenshot

Before:
The covers should be the grey default book cover, and there should be up/down arrows next to the headers

After:

Stakeholders

[cdrini]

@RayBB would you be willing to take a look at this one and test it on local/gitpod?

[RayBB]

@cdrini
I assume this is to fix #5834 ?

On gitpod it doesn't seem to work:

[jimchamp]

Is this branch causing this?

[cdrini]

^ Yep it was causing that issue! @RayBB 's fixes to the service worker have now also fixed this issue, so I have put it back up on testing and it should be working!

@scottbarnes tested on the local environment and confirmed it didn't break
I tested on testing.openlibrary.org and confirmed it is working.
@rebecca-shoptaw Can you check on gitpod?

(For anyone curious, this was previously failing because the service worker was caching the redirect responses from /images incorrectly; but @RayBB 's fixes have now fixed that issue as well!)

[cdrini]

Ah it only works on a hard refresh, ctrl-shift-r, because the service worker is caching the 303 redirect response incorrectly... darn! Still an improvement though; it at least provides a workaround (press ctrl-shift-r)

[cdrini]

Ok I think I fixed the service worker issues issue with that last commit, so it should work! I unfortunately wasn't able to test since gitpod wasn't coming up for me 🥲 But if you can test it @rebecca-shoptaw , that would be awesome!

Note I think you'll need to run make js inside the container before the fix takes affect, but then it should work after a ctrl-shift-r, and after many normal ctrl-r 👍

[rebecca-shoptaw]

@cdrini It seems to be working for me in gitpod! Confirmed the little triangle error icon and the loading indicator for the cover form now appear as on testing -- and this is without needing to build js or hard refresh!

[rebecca-shoptaw]

LGTM! This should be SO helpful in gitpod :)