Merge pull request #9070 from internetarchive/cdrini-patch-8

Partially fix static images not working in gitpod
internetarchive · Jun 21, 2024 · fc3ae11 · fc3ae11
2 parents e973346 + d8221ef
commit fc3ae11
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/openlibrary/plugins/openlibrary/js/service-worker.js b/openlibrary/plugins/openlibrary/js/service-worker.js
@@ -49,6 +49,7 @@ registerRoute(
                 maxEntries: 100,
                 maxAgeSeconds: DAY_SECONDS * 365,
             }),
+            cacheableResponses
         ],
     })
 );

diff --git a/openlibrary/plugins/upstream/code.py b/openlibrary/plugins/upstream/code.py
@@ -37,12 +37,13 @@
 logger = logging.getLogger('openlibrary.plugins.upstream.code')
 
 
+# Note: This is done in web_nginx.conf on production ; this endpoint is
+# only used in development/gitpod.
 class static(delegate.page):
     path = "/images/.*"
 
     def GET(self):
-        host = 'https://%s' % web.ctx.host if 'openlibrary.org' in web.ctx.host else ''
-        raise web.seeother(host + '/static' + web.ctx.path)
+        return web.seeother(f'/static{web.ctx.path}')
 
 
 class history(delegate.mode):
-Original file line number
+Diff line change
@@ Expand Up / @@ -49,6 +49,7 @@ registerRoute( @@
                     maxEntries: 100,
                     maxAgeSeconds: DAY_SECONDS * 365,
                 }),
+                cacheableResponses
             ],
         })
     );
@@ Expand Down @@