Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

allow the addon to be enabled/disabled through configuration #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GavinJoyce
Copy link
Member

@GavinJoyce GavinJoyce commented May 9, 2019

This allows the addon to be enabled / disabled through configuration in ember-cli-build.js:

'ember-cli-deprecation-workflow': {
  enabled: true,
},

Let's use this in our app for a little while first before considering if we should try to upstream it to https://github.com/mixonic/ember-cli-deprecation-workflow

@himynameisjonas
Copy link

Hi,
Have you tried it out for a little while now? 😄

This patch would help us at Teamtailor since our main app doesn't include any tests in the development builds so the app.tests check doesn't work for us.

himynameisjonas added a commit to Teamtailor/ember-cli-deprecation-workflow that referenced this pull request Oct 20, 2020
@GavinJoyce
Copy link
Member Author

👋 We still use this option, yes. It would be great to add this to mixonic/ember-cli-deprecation-workflow. Perhaps you'd be interested in submitting a PR?

@himynameisjonas
Copy link

👋 We still use this option, yes. It would be great to add this to mixonic/ember-cli-deprecation-workflow. Perhaps you'd be interested in submitting a PR?

I've opened a PR based on your work now 👍
ember-cli#88

@GavinJoyce
Copy link
Member Author

Nice one, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants