Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config option for enabling/disabling the add-on. #88

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

himynameisjonas
Copy link
Contributor

This allows the addon to be enabled / disabled through configuration in ember-cli-build.js:

'ember-cli-deprecation-workflow': {
  enabled: true,
},

Useful when your app doesn't include test files in the development environment.

Based on @GavinJoyce's fork.

@mixonic
Copy link
Member

mixonic commented Jul 5, 2021

Excellent! Thanks @himynameisjonas @GavinJoyce

@mixonic mixonic merged commit e5ffa71 into ember-cli:master Jul 5, 2021
@LevelbossMike
Copy link
Member

LevelbossMike commented Aug 11, 2021

@mixonic I was running into an issue where I disabled the tests in development and deprecation workflow wasn't working as specified in the README with version 2.0.0.

Can you please cut a release for this change when you find the time to do so? No hurry obviously but would be great if we could point to a proper release in package.json instead of a sha.

@himynameisjonas himynameisjonas deleted the config-option branch August 11, 2021 13:07
@himynameisjonas
Copy link
Contributor Author

@LevelbossMike FYI there has been a new release now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants