[SYCL][Graph][Doc] Specify API for whole graph updates #13253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
reviewed
Apr 3, 2024
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
|
We could use a more detailed PR description of what this feature is, since developers may come across it that are not directly on the graphs team. Can also put |
fabiomestre
changed the title
sommerlukas
pushed a commit
that referenced
this pull request
Apr 9, 2024
Implementation of spec PR #13253
EwanC
reviewed
May 23, 2024
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
julianmi
reviewed
May 24, 2024
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
al42and
reviewed
May 28, 2024
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
al42and
reviewed
May 28, 2024
gmlueck
reviewed
May 30, 2024
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
- Clarify what topologically identical means - Clarify what oeprations must be in the same order - Minor wording changes
- Allow barrier and empty nodes in whole-graph update - Minor topology wording clarifications
|
Tagging @gmlueck to review new changes. |
gmlueck
reviewed
Jun 18, 2024
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Jun 20, 2024
In order to enable the minimum viable real life usecase for the Whole Graph Update feature. Allow graphs to contain empty nodes and barrier nodes during update. See discussion thread intel#13253 (comment) on SYCL-Graph spec PR for publicizing the availability of the Whole Graph Update feature.
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Jun 20, 2024
In order to enable the minimum viable real life usecase for the Whole Graph Update feature. Allow graphs to contain empty nodes and barrier nodes during update. See discussion thread intel#13253 (comment) on SYCL-Graph spec PR for publicizing the availability of the Whole Graph Update feature.
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Jun 20, 2024
In order to enable the minimum viable real life usecase for the Whole Graph Update feature. Allow graphs to contain empty nodes and barrier nodes during update. See discussion thread intel#13253 (comment) on SYCL-Graph spec PR for publicizing the availability of the Whole Graph Update feature.
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Jun 20, 2024
In order to enable the minimum viable real life usecase for the Whole Graph Update feature. Allow graphs to contain empty nodes and barrier nodes during update. See discussion thread intel#13253 (comment) on SYCL-Graph spec PR for publicizing the availability of the Whole Graph Update feature.
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Jun 21, 2024
In order to enable the minimum viable real life usecase for the Whole Graph Update feature. Allow graphs to contain empty nodes and barrier nodes during update. See discussion thread intel#13253 (comment) on SYCL-Graph spec PR for publicizing the availability of the Whole Graph Update feature.
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Jun 24, 2024
In order to enable the minimum viable real life usecase for the Whole Graph Update feature. Allow graphs to contain empty nodes and barrier nodes during update. See discussion thread intel#13253 (comment) on SYCL-Graph spec PR for publicizing the availability of the Whole Graph Update feature.
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Jun 24, 2024
In order to enable the minimum viable real life usecase for the Whole Graph Update feature. Allow graphs to contain empty nodes and barrier nodes during update. See discussion thread intel#13253 (comment) on SYCL-Graph spec PR for publicizing the availability of the Whole Graph Update feature.
steffenlarsen
pushed a commit
that referenced
this pull request
Jun 25, 2024
In order to enable the minimum viable GROMACS use case for the Whole Graph Update feature, allow graphs to contain empty nodes and barrier nodes during update. See discussion thread #13253 (comment) on SYCL-Graph spec PR for publicizing the availability of the Whole Graph Update feature.
EwanC
reviewed
Jul 1, 2024
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
EwanC
force-pushed
the
fabio/whole-graph_update
branch
from
0c42b9a
to
c4183c8
Compare
Avoid mixing UB and exception conditions of topologically identical. Only specify violating topologically identical conditions as UB.
EwanC
force-pushed
the
fabio/whole-graph_update
branch
from
c4183c8
to
5506590
Compare
gmlueck
approved these changes
Jul 3, 2024
EwanC
approved these changes
Jul 3, 2024
|
@intel/llvm-gatekeepers This is ready to merge, thanks |
|
hey @EwanC there's still a pending review request for @AerialMantis. Do you want to wait for that or just get it merged? |
Gordon is not a required reviewer and this PR has been open for a long time for feedback, so I'd prefer to merge now. If there's any feedback after the fact we can open a new PR to address it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds API entries and descriptions for the whole graph update feature, which allows updating an executable
command_graphusing another modifiable graph with the same topology. This provides a cleaner alternative to individual node update, especially when using graph recording or updating a large number of parameters.The PR also includes a small usage example.