[SYCL][Graph] Implementation of whole graph update #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
reviewed
Apr 1, 2024
There was a problem hiding this comment.
A few comments, but looking good.
I think we could also have tests for the following cases:
- Test update using a graph with a nested sub-graph in it.
- Test update in the case where there's no update to the inputs with the new input graph to make sure it's not an error, as we've not specified any error.
Bensuo
reviewed
Apr 2, 2024
Bensuo
reviewed
Apr 3, 2024
sycl/source/detail/graph_impl.cpp
Outdated
Comment on lines
1173
to
1184
| throw sycl::exception(sycl::make_error_code(errc::invalid), | ||
| "Mismatch found in the number of nodes. The graphs " | ||
| "must have a matching topology."); | ||
| } else { | ||
| for (uint32_t i = 0; i < MNodeStorage.size(); ++i) { | ||
| if (MNodeStorage[i]->MSuccessors.size() != | ||
| GraphImpl->MNodeStorage[i]->MSuccessors.size() || | ||
| MNodeStorage[i]->MPredecessors.size() != | ||
| GraphImpl->MNodeStorage[i]->MPredecessors.size()) { | ||
| throw sycl::exception(sycl::make_error_code(errc::invalid), | ||
| "Mismatch found in the number of edges. The " | ||
| "graphs must have a matching topology."); |
There was a problem hiding this comment.
Same nit as before I think these error messages could be more explicit that this is the update operation.
|
Upstream PR: https://github.com/intel/llvm/pull/13220/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.