[SYCL][Graph] Fix potential issue with command buffer commands #13224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bensuo
commented
Apr 1, 2024
Bensuo
commented
- Fix uninitialized pointer values leading to trying to call piExtCommandBufferReleaseCommand on backends which don't support update, which may return as an unsupported feature. Initializing pointers to 0 prevents this call from happening.
- Fix uninitialized pointer values leading to trying to call unsupported features on backends which don't support update.
EwanC
approved these changes
Apr 1, 2024
|
@intel/llvm-gatekeepers Can we merge this please |
|
There are unrelated linux build failures in the post-commit: https://github.com/intel/llvm/actions/runs/8523440696/job/23345721563 Also seems to be affecting other recent post-commit runs. |
|
Yeah, this is tracked in #13225. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.