Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-commit compilation fails with undefined reference to `__exp10' #13225

Closed
sommerlukas opened this issue Apr 1, 2024 · 12 comments
Closed
Labels
bug Something isn't working

Comments

@sommerlukas
Copy link
Contributor

Describe the bug

Compilation of DPC++ itself fails in the post-commit pipeline.

The error message is:

AMDGPULibCalls.cpp:(.text._ZN4llvm14AMDGPULibCalls22evaluateScalarMathFuncERKNS_13AMDGPULibFuncERdS4_PNS_8ConstantES6_+0x31e): undefined reference to `__exp10'

To reproduce

For example, see post-commit pipeline here: https://github.com/intel/llvm/actions/runs/8506162269/job/23295912063

Environment

Post-commit pipeline on Linux

Additional context

No response

@sommerlukas sommerlukas added the bug Something isn't working label Apr 1, 2024
@sommerlukas
Copy link
Contributor Author

@jsji As this started to fail soon after the pulldown last week (#13103), do you think there's a chance of this being related to the pulldown?

@al42and
Copy link
Contributor

al42and commented Apr 1, 2024

I have a similar issue when compiling code with DPC++ (DPC++ itself builds fine somehow). 9848fa4 seems to be the culprit.

UPD: It was reverted upstream, so another pulldown should solve the problem.

@jsji
Copy link
Contributor

jsji commented Apr 1, 2024

I have a similar issue when compiling code with DPC++ (DPC++ itself builds fine somehow). 9848fa4 seems to be the culprit.

UPD: It was reverted upstream, so another pulldown should solve the problem.

Thanks @al42and , yes, eefef900c6a24f2acd is latest pulldown. #13190

@bader
Copy link
Contributor

bader commented Apr 1, 2024

@sommerlukas, #13190 is merged. Please, close the issue if the problem is fixed.

@sommerlukas
Copy link
Contributor Author

@bader @jsji Post-commit for the pulldown in #13190 failed with the same error message as described above, so it seems that the pulldown did not fix the issue.

https://github.com/intel/llvm/actions/runs/8510917365/job/23309509875

@jsji
Copy link
Contributor

jsji commented Apr 2, 2024

@bader @jsji Post-commit for the pulldown in #13190 failed with the same error message as described above, so it seems that the pulldown did not fix the issue.

https://github.com/intel/llvm/actions/runs/8510917365/job/23309509875

Hmm... If so, then the culprit commit is NOT 9848fa4. Or this is CI env issue.

@jsji
Copy link
Contributor

jsji commented Apr 2, 2024

I tried to do a self-build locally, but my build passed.

/iusers/jinsongj/llvm/build# /iusers/jinsongj/llvm/install/bin/clang++ -v
clang version 19.0.0git (https://github.com/intel/llvm.git fce067000ae1d9893410e6b04ebf60d3f7df9f86)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /iusers/jinsongj/llvm/install/bin
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/11
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/9
Selected GCC installation: /usr/lib/gcc/x86_64-linux-gnu/11
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Candidate multilib: x32;@mx32
Selected multilib: .;@m64
/iusers/jinsongj/llvm/build# grep CMAKE_C.*COMPILER: CMakeCache.txt
CMAKE_CXX_COMPILER:FILEPATH=/iusers/jinsongj/llvm/install/bin/clang++
CMAKE_C_COMPILER:FILEPATH=/iusers/jinsongj/llvm/install/bin/clang
/iusers/jinsongj/llvm/build# objdump -t lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPULibCalls.cpp.o|grep exp10
0000000000000000 l     O .rodata._ZL9tbl_exp10  0000000000000030 _ZL9tbl_exp10
0000000000000000 l    d  .rodata._ZL9tbl_exp10  0000000000000000 .rodata._ZL9tbl_exp10

@jsji
Copy link
Contributor

jsji commented Apr 2, 2024

I am able to reproduce the failures using old SYCL driver.

root@pod-ub22l-scsel-clx-20:/iusers/jinsongj/llvm/build# clang++ -v
clang version 19.0.0git (https://github.com/intel/llvm.git 5f2411c2230f1f2a80f1fb13503f405eb357c368)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /iusers/jinsongj/llvm/install/bin
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/11
Found candidate GCC installation: /usr/lib/gcc/x86_64-linux-gnu/9
Selected GCC installation: /usr/lib/gcc/x86_64-linux-gnu/11
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Candidate multilib: x32;@mx32
Selected multilib: .;@m64
root@pod-ub22l-scsel-clx-20:/iusers/jinsongj/llvm/build# objdump -t lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPULibCalls.cpp.o|grep exp10
0000000000000000 l     O .rodata._ZL9tbl_exp10  0000000000000030 _ZL9tbl_exp10
0000000000000000 l    d  .rodata._ZL9tbl_exp10  0000000000000000 .rodata._ZL9tbl_exp10
0000000000000000         *UND*  0000000000000000 __exp10

@jsji
Copy link
Contributor

jsji commented Apr 2, 2024

  # Docker image has last nightly pre-installed and added to the PATH
  build_image: "ghcr.io/intel/llvm/sycl_ubuntu2204_nightly:build"

Ah.. Looks like we ONLY update the build compiler (clang++) in nightly, that is why the post-commit CI still failing.
We should be fine once we have the nightly container updated to include the new pulldown commits.

@jsji
Copy link
Contributor

jsji commented Apr 2, 2024

And unfortunately, the latest nightly docker image is not updated due to a recent bug.

https://github.com/intel/llvm/actions/runs/8503213589/job/23288710904

@jsji
Copy link
Contributor

jsji commented Apr 2, 2024

#13252 to fix the nightly docker image out of date issue.

aelovikov-intel pushed a commit that referenced this issue Apr 2, 2024
Similar to #13245

This should fix the self-build issue reported in
#13225
@sommerlukas
Copy link
Contributor Author

The post-commit failure in the "Commit" stage seems resolved, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants