Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control/rdt: fix discovery of pod qos classes in discovery mode #714

Merged
merged 1 commit into from
Sep 27, 2021
Merged

control/rdt: fix discovery of pod qos classes in discovery mode #714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pkg/cri/resource-manager/control/rdt/rdt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const (
// rdtctl encapsulates the runtime state of our RTD enforcement/controller.
type rdtctl struct {
cache cache.Cache // resource manager cache
noQoSClasses bool // true if we run without any classes configured
noQoSClasses bool // true if mapping pod qos class to rdt class is disabled
mode OperatingMode // track the mode here to capture mode changes
opt *config
}
Expand Down Expand Up @@ -316,10 +316,10 @@ func (ctl *rdtctl) configure() error {
return rdtError("failed to discover classes from fs: %v", err)
}

// Set idle to true if none of the Pod QoS class equivalents exist
// Disable mapping from Pod QoS to RDT class if no Pod QoS class equivalents exist
ctl.noQoSClasses = true
cs := []corev1.PodQOSClass{corev1.PodQOSBestEffort, corev1.PodQOSBurstable, corev1.PodQOSGuaranteed}
for c := range cs {
for _, c := range cs {
if _, ok := rdt.GetClass(string(c)); ok {
ctl.noQoSClasses = false
break
Expand All @@ -338,6 +338,7 @@ func (ctl *rdtctl) configure() error {
if err := rdt.SetConfig(&ctl.opt.Config, true); err != nil {
return err
}
// Disable mapping from Pod QoS to RDT class if no classes have been defined
ctl.noQoSClasses = len(rdt.GetClasses()) <= 1
ctl.mode = ctl.opt.Options.Mode
ctl.assignAll("")
Expand Down