Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

control/rdt: fix discovery of pod qos classes in discovery mode #714

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Sep 27, 2021

Search RDT classes based on their name, not based on their index in our internal array. Also, update code comments.

jukkar
jukkar previously approved these changes Sep 27, 2021
Copy link
Contributor

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this fixes the linter error.

@marquiz
Copy link
Contributor Author

marquiz commented Sep 27, 2021

Hmm, hold on, do not merge this yet

askervin
askervin previously approved these changes Sep 27, 2021
Copy link
Contributor

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marquiz marquiz dismissed stale reviews from askervin and jukkar via 5917ba2 September 27, 2021 08:43
@marquiz marquiz changed the title control/rdt: fix "discovery" mode control/rdt: fix discovery of pod qos classes in ddiscovery mode Sep 27, 2021
@marquiz marquiz changed the title control/rdt: fix discovery of pod qos classes in ddiscovery mode control/rdt: fix discovery of pod qos classes in discovery mode Sep 27, 2021
Search RDT classes based on their name, not based on their index in our
internal array. Also, update code comments.
@marquiz
Copy link
Contributor Author

marquiz commented Sep 27, 2021

Now ready for review. Updated some code comments

Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jukkar jukkar merged commit 4cec89f into intel:master Sep 27, 2021
@klihub klihub mentioned this pull request Oct 5, 2021
25 tasks
@marquiz marquiz deleted the fixes/rdt branch November 23, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants