Optionally read EXIF data in ImageSource driver #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ots22
commented
Nov 9, 2021
|
Please update fsspec/s3fs in the test envs to get the CI to pass again |
|
Worth running the CI again to see if the last commit has fixed it? It brings in the upstream CI changes from #111 which looks like it might help. |
|
running |
|
Well I guess that wasn't it! Any ideas? |
|
cf #115 |
|
Anything I can do to help this get merged? |
|
@aaronspring , this is the same rasterio thing. I suppose we can merge here anyway. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for the ImageSource driver to read EXIF tags from images.
If
exif_tagspassed to the constructor is truthy, a Dataset is returned with the image and EXIF tags as data variables (just the ones specified if a list). Otherwise the behaviour is unchanged (a DataArray representing the image is returned).ImageSource seemed like the best place for this functionality, but would be happy to submit a new PR if it better belongs elsewhere.
Known issue
See the comment below