Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin intake_xarray version #367

Merged
merged 8 commits into from
Nov 9, 2022
Merged

Pin intake_xarray version #367

merged 8 commits into from
Nov 9, 2022

Conversation

edwardchalstrey1
Copy link
Contributor

@edwardchalstrey1 edwardchalstrey1 commented Nov 8, 2022

@ots22 it looks like the only reason the plankton notebook was working correctly is because the environment it uses was installing intake_xarray directly from your fork. I'm not sure why... ok this is actually the same issue as #362 so I will pin the version instead. Presumably the older version of intake_xarray was from before your PR was merged.

Closes #362

TODO

  • a support table in the docs
  • change to middle number version release e.g. 0.4.0
  • Removal of Python 3.7 from GH actions

@edwardchalstrey1 edwardchalstrey1 added the bug Something isn't working label Nov 8, 2022
@edwardchalstrey1
Copy link
Contributor Author

edwardchalstrey1 commented Nov 8, 2022

Ok @ots22 this is fun... we seem to break Python 3.7 functionality via this change, because the version of xarray that intake_xarray needs isn't available for that Python version, from CI:

INFO: pip is looking at multiple versions of <Python from Requires-Python> to determine which version is compatible with other requirements. This could take a while.
INFO: pip is looking at multiple versions of scivision to determine which version is compatible with other requirements. This could take a while.
ERROR: Ignored the following versions that require a different python version: 0.21.0 Requires-Python >=3.8; 0.21.1 Requires-Python >=3.8; 2022.10.0 Requires-Python >=3.8; 2022.11.0 Requires-Python >=3.8; 2022.3.0 Requires-Python >=3.8; 2022.6.0 Requires-Python >=3.8; 2022.6.0rc0 Requires-Python >=3.8; 2022.9.0 Requires-Python >=3.8; 3.6.0 Requires-Python >=3.8; 3.6.0rc1 Requires-Python >=3.8; 3.6.0rc2 Requires-Python >=3.8; 3.6.1 Requires-Python >=3.8; 3.6.2 Requires-Python >=3.8; 8.0.0 Requires-Python >=3.8; 8.0.0a1 Requires-Python >=3.8; 8.0.0b1 Requires-Python >=3.8; 8.0.0rc1 Requires-Python >=3.8; 8.0.1 Requires-Python >=3.8; 8.1.0 Requires-Python >=3.8; 8.1.1 Requires-Python >=3.8; 8.2.0 Requires-Python >=3.8; 8.3.0 Requires-Python >=3.8; 8.4.0 Requires-Python >=3.8; 8.5.0 Requires-Python >=3.8; 8.6.0 Requires-Python >=3.8
ERROR: Could not find a version that satisfies the requirement xarray>=02022 (from intake-xarray) (from versions: 0.7.0, 0.7.1, 0.7.2, 0.8.0rc1, 0.8.0, 0.8.1, 0.8.2, 0.9.0rc1, 0.9.0, 0.9.1, 0.9.2, 0.9.3, 0.9.4, 0.9.5, 0.9.6, 0.10.0rc1, 0.10.0rc2, 0.10.0, 0.10.1, 0.10.2, 0.10.3, 0.10.4, 0.10.5, 0.10.6, 0.10.7, 0.10.8, 0.10.9, 0.11.0, 0.11.1, 0.11.2, 0.11.3, 0.12.0, 0.12.1, 0.12.2, 0.12.3, 0.13.0, 0.14.0, 0.14.1, 0.15.0, 0.15.1, 0.16.0, 0.16.1, 0.16.2, 0.17.0, 0.18.0, 0.18.1, 0.18.2, 0.19.0, 0.20.0, 0.20.1, 0.20.2)
ERROR: No matching distribution found for xarray>=02022
Error: Process completed with exit code 1.

Do you think we should abandon Python 3.7?

@edwardchalstrey1 edwardchalstrey1 changed the title Use exif feature from ots22 fork of intake-xarray Pin intake_xarray version Nov 8, 2022
@ots22
Copy link
Member

ots22 commented Nov 8, 2022

Python >= 3.8 sounds sensible - perhaps we could do something similar to numpy and support a minimum python version that changes over time with the scivision version. Like this: https://numpy.org/neps/nep-0029-deprecation_policy.html#support-table

@edwardchalstrey1
Copy link
Contributor Author

@ots22 do you know how to stop the GH action that I'm removing from preventing merge?

@ots22
Copy link
Member

ots22 commented Nov 8, 2022

The required checks are those named in the settings, but if one with that name doesn't exist it won't ever complete and the CI will be 'waiting' forever! Look under settings for branch protection rules (under branches I think).

@edwardchalstrey1
Copy link
Contributor Author

The required checks are those named in the settings, but if one with that name doesn't exist it won't ever complete and the CI will be 'waiting' forever! Look under settings for branch protection rules (under branches I think).

Thanks @ots22 let me know if you're happy with these changes now

@ots22
Copy link
Member

ots22 commented Nov 8, 2022

Overall looks good to me!

I think the numpy table is suggesting versions of both python and numpy that community software should support, based on the date. Maybe we should do something like that, targeted at model authors for example? Is that the meaning of your table?

Alternatively, we could just list scivision (only) support by python version - I'll have a go as a suggestion, one second (feel free to reject)...

README.md Outdated Show resolved Hide resolved
Co-authored-by: ots22 <ots22@users.noreply.github.com>
@edwardchalstrey1 edwardchalstrey1 merged commit 5687b99 into main Nov 9, 2022
@edwardchalstrey1 edwardchalstrey1 deleted the use-ots22-intake_xarray branch November 9, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify intake_xarray version in scivision requirements
2 participants