-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin intake_xarray version #367
Conversation
Ok @ots22 this is fun... we seem to break Python 3.7 functionality via this change, because the version of
Do you think we should abandon Python 3.7? |
Python >= 3.8 sounds sensible - perhaps we could do something similar to numpy and support a minimum python version that changes over time with the scivision version. Like this: https://numpy.org/neps/nep-0029-deprecation_policy.html#support-table |
@ots22 do you know how to stop the GH action that I'm removing from preventing merge? |
The required checks are those named in the settings, but if one with that name doesn't exist it won't ever complete and the CI will be 'waiting' forever! Look under settings for branch protection rules (under branches I think). |
Thanks @ots22 let me know if you're happy with these changes now |
Overall looks good to me! I think the numpy table is suggesting versions of both python and numpy that community software should support, based on the date. Maybe we should do something like that, targeted at model authors for example? Is that the meaning of your table? Alternatively, we could just list scivision (only) support by python version - I'll have a go as a suggestion, one second (feel free to reject)... |
Co-authored-by: ots22 <ots22@users.noreply.github.com>
@ots22 it looks like the only reason the plankton notebook was working correctly is because the environment it uses was installing
intake_xarray
directly from your fork. I'm not sure why... ok this is actually the same issue as #362 so I will pin the version instead. Presumably the older version ofintake_xarray
was from before your PR was merged.Closes #362
TODO
0.4.0