Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(integration): inject Google Drive OAuth details to pipeline and console #1143

Merged
merged 2 commits into from
Oct 31, 2024
Merged

feat(integration): inject Google Drive OAuth details to pipeline and console #1143

merged 2 commits into from
Oct 31, 2024

Conversation

jvallesm
Copy link
Collaborator

Because

  • Google Drive component will need the OAuth client secret and ID injected
    as an environment variable.
  • These values are required in console, too. We need to define them in a
    single place.
  • It can be interesting to define other component values such as the AI
    component API keys.

This commit

  • Defines the global component secrets as environment values and injects
    them into the required services.

@jvallesm jvallesm self-assigned this Oct 29, 2024
@linear Linear
Copy link

linear bot commented Oct 29, 2024

INS-6570 Pass OAuth client and secret IDs to backend and frontend

@jvallesm
Copy link
Collaborator Author

QA ✅

After make latest PROFILE=all, the variables can be read from the containers. Additinally, I tried an OpenAI component in a pipeline without setup.

console

7b4b29614ecf:/app$ echo $INTEGRATION_GOOGLE_DRIVE_CLIENT_SECRET
GOCSPX-...
7b4b29614ecf:/app$

pipeline-backend

/pipeline-backend $ echo $CFG_CONNECTOR_SECRETS_OPENAI_APIKEY
sk-...
/pipeline-backend $

@jvallesm jvallesm marked this pull request as ready for review October 29, 2024 12:44
@jvallesm jvallesm force-pushed the jvalles/ins-6570-pass-oauth-client-and-secret-ids-to-backend-and-frontend branch from dfde520 to c086902 Compare October 29, 2024 13:45
@jvallesm jvallesm force-pushed the jvalles/ins-6570-pass-oauth-client-and-secret-ids-to-backend-and-frontend branch from c086902 to 56be0a2 Compare October 29, 2024 13:46
@jvallesm jvallesm force-pushed the jvalles/ins-6570-pass-oauth-client-and-secret-ids-to-backend-and-frontend branch from 2847794 to e05aaf2 Compare October 30, 2024 14:06
@jvallesm jvallesm mentioned this pull request Oct 31, 2024
Merged
donch1989
donch1989 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvallesm jvallesm merged commit 7ccf5ae into main Oct 31, 2024
13 checks passed
@jvallesm jvallesm deleted the jvalles/ins-6570-pass-oauth-client-and-secret-ids-to-backend-and-frontend branch October 31, 2024 07:01
@droplet-bot droplet-bot mentioned this pull request Oct 31, 2024
Merged
donch1989 pushed a commit that referenced this pull request Nov 5, 2024
@droplet-bot
chore(main): release 0.45.0-beta (#1144)
71e7209 
🤖 I have created a release *beep* *boop*
---


##
[0.45.0-beta](v0.44.1-beta...v0.45.0-beta)
(2024-11-05)


### Features

* **integration:** inject Google Drive OAuth details to pipeline and
console
([#1143](#1143))
([7ccf5ae](7ccf5ae))


### Bug Fixes

* **api-gateway:** add minio port in _helpers.tpl
([#1147](#1147))
([04e8205](04e8205))
* **component:** add dummy OAuth information for pipeline-backend tests
([#1145](#1145))
([30bce6f](30bce6f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@Sarthak-instill Sarthak-instill Awaiting requested review from Sarthak-instill Sarthak-instill is a code owner

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

Assignees

@jvallesm jvallesm

Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvallesm @donch1989 @droplet-bot