feat(integration): identify supported OAuth integrations through global secrets #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvallesm
force-pushed
the
jvalles/ins-6570-pass-oauth-client-and-secret-ids-to-backend-and-frontend
branch
5 times, most recently
from
c37edff to
a53b09a
Compare
donch1989
previously approved these changes
Oct 31, 2024
jvallesm
commented
Oct 31, 2024
jvallesm
force-pushed
the
jvalles/ins-6570-pass-oauth-client-and-secret-ids-to-backend-and-frontend
branch
from
a53b09a to
f39a3ad
Compare
jvallesm
commented
Oct 31, 2024
There was a problem hiding this comment.
ℹ️ @chuang8511 I extracted the OAuth support logic from the individual components as, at least for now, it will be the same code. Have a look at how I added it in the individual components github and slack (both in the component's main and on the store initialiser).
jvallesm
deleted the
jvalles/ins-6570-pass-oauth-client-and-secret-ids-to-backend-and-frontend
branch
jvallesm
added a commit
to instill-ai/api-gateway
that referenced
this pull request
Oct 31, 2024
…#264) Because - instill-ai/pipeline-backend#791 introduced a environment variable dependency in the integration tests. This commit - Adds the environment variable to `instill-cloud` setup in CI.
donch1989
pushed a commit
that referenced
this pull request
Nov 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.46.0-beta](v0.45.2-beta...v0.46.0-beta) (2024-11-05) ### Features * add `condition` field support for iterator ([#803](#803)) ([04b1252](04b1252)) * add markdowns per pages ([#792](#792)) ([3ee428e](3ee428e)) * add resolution field ([#808](#808)) ([f15f6bf](f15f6bf)) * add task sync ([#793](#793)) ([41a1eeb](41a1eeb)) * **component,audio:** add TASK_DETECT_ACTIVITY and TASK_SEGMENT ([#762](#762)) ([9e92a31](9e92a31)) * **component,http:** refactor `restapi` component to `http` component ([#797](#797)) ([c2b1862](c2b1862)) * **component:** add error handling for missing conversation ([#806](#806)) ([54cc616](54cc616)) * **component:** inject global secrets as environment variables ([#786](#786)) ([8d842a6](8d842a6)) * convert time type to string ([#809](#809)) ([7de8465](7de8465)) * **googledrive:** add the tasks for google drive ([#725](#725)) ([b6fe968](b6fe968)) * **integration:** identify supported OAuth integrations through global secrets ([#791](#791)) ([5a96453](5a96453)) * **minio:** import updated minio package and add tag on file upload ([#779](#779)) ([ef86318](ef86318)) * revamp Instill Format ([#774](#774)) ([24153e2](24153e2)) * support `length` attribute for array data ([#810](#810)) ([fb4f4f7](fb4f4f7)) * **web:** refactor the web operator ([#772](#772)) ([ae4e3c2](ae4e3c2)) ### Bug Fixes * **component,image:** fix missing show score draw ([#801](#801)) ([a405bf7](a405bf7)) * fix bug not to return error if there is no app or conversation ([#816](#816)) ([a946cfd](a946cfd)) * fix iterator upstream check ([#794](#794)) ([671971f](671971f)) * **run:** add metadata retention handler ([#800](#800)) ([25ec0c2](25ec0c2)) * **run:** add namespace id in response ([#811](#811)) ([8d29ffb](8d29ffb)) * **run:** rename pipeline run columns and fix tests ([#776](#776)) ([98f1e00](98f1e00)) * **slack:** correct link to OAuth config in documentation ([#805](#805)) ([aa0752d](aa0752d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
definition.
This commit
component global secrets have a complete OAuth configuration.