Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2: Minimum prototype for pilot #4

Merged
merged 58 commits into from
Nov 16, 2022
Merged

2: Minimum prototype for pilot #4

merged 58 commits into from
Nov 16, 2022

Conversation

danielinteractive
Copy link
Contributor

closes #2

@danielinteractive
Copy link
Contributor Author

@cicdguy ok let me create the upstream branches for the other repos to fix the yaml's ...
now I remember why it would be great to avoid this in staged dependencies :-)

cicdguy and others added 2 commits October 3, 2022 09:55
add `rtables` upstream dependency

Signed-off-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
@danielinteractive
Copy link
Contributor Author

@cicdguy we still get the nestcolor staged dependencies problem:
image
I already tried rerunning the checks but that does not help. any idea?

@cicdguy
Copy link
Contributor

cicdguy commented Oct 5, 2022

@walkowif - would you be able to assist with this? We're trying to resolve some cross-repo dependencies using staged.dependencies here.

@walkowif
Copy link
Contributor

walkowif commented Oct 6, 2022

Looks like nestcolor was not added to DESCRPTION. After I added it, staged dependencies pass.

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @edelarua and @danielinteractive
I think this is almost ready. approve this PR to unblock work as I am ooo this week. Thanks!

@shajoezhu
Copy link
Contributor

hi @edelarua , could you resolve the conflict on this branch please. Thanks!

@edelarua
Copy link
Contributor

edelarua commented Nov 15, 2022

@danielinteractive @shajoezhu Almost all checks are passing now except for the staged.dependencies check. I see that Dinakar opened a PR a while ago to add nestcolor as an upstream dependency for tern.gee (insightsengineering/nestcolor#36). Is this a dependency we still want to include?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2022

badge

Code Coverage Summary

Filename            Stmts    Miss  Cover    Missing
----------------  -------  ------  -------  ---------
R/fit_gee.R            89       4  95.51%   101-104
R/gee_methods.R        24       1  95.83%   52
R/lsmeans.R            38       0  100.00%
R/tabulate_gee.R       54      19  64.81%   21, 28-48
TOTAL                 205      24  88.29%

Diff against main

Filename            Stmts  Miss    Cover
----------------  -------  ------  --------
R/fit_gee.R           +89  +4      +95.51%
R/gee_methods.R       +24  +1      +95.83%
R/lsmeans.R           +38  -       +100.00%
R/tabulate_gee.R      +54  +19     +64.81%
TOTAL                +205  +24     +88.29%

Results for commit: 2de0663

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2022

Unit Tests Summary

  1 files    4 suites   3s ⏱️
22 tests 21 ✔️ 1 💤 0
38 runs  37 ✔️ 1 💤 0

Results for commit 52dbb2a.

♻️ This comment has been updated with latest results.

@edelarua edelarua added the sme label Nov 15, 2022
@shajoezhu
Copy link
Contributor

Hi @edelarua , I think we can keep nestcolor out for tern.gee for now. It is not doing any plotting, we can keep these dependency tree a bit simpler. Thanks!

@edelarua edelarua merged commit 94fd54c into main Nov 16, 2022
@edelarua edelarua deleted the 2_prototype branch November 16, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum prototype functionality to support pilot application
6 participants