-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2: Minimum prototype for pilot #4
Conversation
Signed-off-by: Dinakar <26552821+cicdguy@users.noreply.github.com>
@cicdguy ok let me create the upstream branches for the other repos to fix the yaml's ... |
add `rtables` upstream dependency Signed-off-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
@cicdguy we still get the |
@walkowif - would you be able to assist with this? We're trying to resolve some cross-repo dependencies using staged.dependencies here. |
Looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks @edelarua and @danielinteractive
I think this is almost ready. approve this PR to unblock work as I am ooo this week. Thanks!
hi @edelarua , could you resolve the conflict on this branch please. Thanks! |
@danielinteractive @shajoezhu Almost all checks are passing now except for the staged.dependencies check. I see that Dinakar opened a PR a while ago to add |
Code Coverage Summary
Diff against main
Results for commit: 2de0663 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Hi @edelarua , I think we can keep nestcolor out for tern.gee for now. It is not doing any plotting, we can keep these dependency tree a bit simpler. Thanks! |
closes #2