rename qenv #733
Merged
rename qenv #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
This was referenced Sep 20, 2022
Polkas
reviewed
Sep 20, 2022
Polkas
reviewed
Sep 20, 2022
Polkas
reviewed
Sep 20, 2022
Polkas
reviewed
Sep 20, 2022
| @@ -0,0 +1,52 @@ | |||
| #' @export | |||
There was a problem hiding this comment.
some tests for these functions will be nice.
Please add roxygen2 docs as are exported.
tdata2env could give bad error outside the reactive context, should we use isolate or add some validation?
There was a problem hiding this comment.
yup all coming 👍
Polkas
reviewed
Sep 20, 2022
Co-authored-by: Maciej Nasinski <maciej.nasinski@contractors.roche.com>
Co-authored-by: Maciej Nasinski <maciej.nasinski@contractors.roche.com>
Co-authored-by: Maciej Nasinski <maciej.nasinski@contractors.roche.com>
Co-authored-by: Maciej Nasinski <maciej.nasinski@contractors.roche.com>
nikolas-burkoff
commented
Sep 20, 2022
mhallal1
reviewed
Sep 21, 2022
mhallal1
reviewed
Sep 21, 2022
mhallal1
reviewed
Sep 21, 2022
Polkas
reviewed
Sep 21, 2022
Co-authored-by: Mahmoud Hallal <86970066+mhallal1@users.noreply.github.com>
Co-authored-by: Maciej Nasinski <maciej.nasinski@contractors.roche.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of insightsengineering/teal.code#34 see insightsengineering/teal.code#74
Still needs
Also closes #722 needs the PRs below: