Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename quosure to qenv #34

Closed
Tracked by #45
gogonzo opened this issue May 21, 2022 · 9 comments · Fixed by #65 or #74
Closed
Tracked by #45

Rename quosure to qenv #34

gogonzo opened this issue May 21, 2022 · 9 comments · Fixed by #65 or #74

Comments

@gogonzo
Copy link
Contributor

gogonzo commented May 21, 2022

Something which fits more and is short enough. I'd like to hear your propositions first.

@gogonzo gogonzo changed the title Find better name for chunks Find better name for new chunks Jul 21, 2022
@gogonzo
Copy link
Contributor Author

gogonzo commented Jul 21, 2022

See some discussion #49 (comment)

@donyunardi donyunardi linked a pull request Aug 19, 2022 that will close this issue
@gogonzo
Copy link
Contributor Author

gogonzo commented Sep 14, 2022

Here are some propositions:

  • codenv
  • repernv
  • tealEnv
  • envexp
  • envcode
  • envc ("c" as a shortcut of "code")
  • envquo
  • ecode / evcode ("e"/"ev" stands for "evaluated")
  • ec
  • ecc (evaluated code container)

Other question:
Do we want to keep it in teal.code or make a new package for this? If we make a new package then we won't need to go through deprecation process of chunks.

@donyunardi
Copy link
Contributor

I'd vote for codenv or envcode.

If we make a new package, are we still going to maintain teal.code?
If yes, then would this possibly confuse user on which one to use?

@nikolas-burkoff
Copy link
Contributor

I would vote for keeping this package and deprecating chunks. I like TealEnv or TealCode but codeenv/envcode are OK as well

@Polkas
Copy link
Contributor

Polkas commented Sep 15, 2022

ecode or envcode

@mhallal1
Copy link
Contributor

As we are already using quosure with _q everywhere, I would suggest quoenv or qenv.

@nikolas-burkoff
Copy link
Contributor

Decided with qenv

@gogonzo
Copy link
Contributor Author

gogonzo commented Sep 16, 2022

Let's use this issue to replace quosure -> qenv in all repos

@pawelru
Copy link
Contributor

pawelru commented Sep 16, 2022

Please don't forget to change filenames (using git mv to keep the history)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants