Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert - full input cycle #677

Merged
merged 2 commits into from
Jun 27, 2022
Merged

revert - full input cycle #677

merged 2 commits into from
Jun 27, 2022

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented Jun 27, 2022

closes #676

So I find out the there is some reactivity from FilteredData, which cases the modules to be CREATED MANY
TIMES from scratch. The fIlter_spec shows us a side effect of it, the filter was reinitialized each time.
We could play here with isolate, still out primary decision was to revert it in such case.

@Polkas Polkas added the core label Jun 27, 2022
@Polkas Polkas marked this pull request as ready for review June 27, 2022 14:33
@Polkas Polkas changed the title conflicts - revert revert - full input cycle Jun 27, 2022
@github-actions
Copy link
Contributor

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------
R/default_filter.R                   7       7  0.00%    17-27
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  17      17  0.00%    19-35
R/get_rcode_utils.R                 52      11  78.85%   42-51, 94, 99
R/get_rcode.R                      145      99  31.72%   71-74, 85-148, 195, 201-202, 233-284
R/include_css_js.R                  20       0  100.00%
R/init.R                            39      21  46.15%   171, 182-183, 236-257
R/log_app_usage.R                   38      38  0.00%    34-119
R/logging.R                         13      13  0.00%    11-28
R/module_nested_tabs.R              76       4  94.74%   57, 137, 188, 194
R/module_tabs_with_filters.R        52       0  100.00%
R/module_teal_with_splash.R         33       2  93.94%   62, 74
R/module_teal.R                    119      20  83.19%   49, 52, 142-143, 156-162, 168-174, 197, 227
R/modules_debugging.R               19      19  0.00%    41-60
R/modules.R                         82       9  89.02%   208, 371-396
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/utils.R                            6       0  100.00%
R/validations.R                     62      39  37.10%   103-355
R/zzz.R                             11       7  36.36%   3-14
TOTAL                              897     389  56.63%

Results for commit: 4779c7d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files    10 suites   10s ⏱️
  92 tests   92 ✔️ 0 💤 0
196 runs  196 ✔️ 0 💤 0

Results for commit b0e2a96.

@Polkas Polkas merged commit f1ec573 into main Jun 27, 2022
@Polkas Polkas deleted the 676_revert_fullcycle@main branch June 27, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tm_outliers: filter_spec defaults when adding a filter in the filter panel
2 participants