tm_outliers: filter_spec defaults when adding a filter in the filter panel

[mhallal1]

What happened?

Using the main branches, run the code below an reproduce the following steps:

1. Change the categortical variable to SEX.
2. Add a filter SEX in the filter panel.
3. The categotical variable filter defaults as below:
   

library(scda)
ADSL <- synthetic_cdisc_data("latest")$adsl

fact_vars_adsl <- names(Filter(isTRUE, sapply(ADSL, is.factor)))
vars <- choices_selected(variable_choices(ADSL, fact_vars_adsl))

app <- init(
  data = cdisc_data(
    cdisc_dataset("ADSL", ADSL, code = "ADSL <- synthetic_cdisc_data(\"latest\")$adsl"),
    check = TRUE
  ),
  modules = modules(
    tm_outliers(
      outlier_var = list(
        data_extract_spec(
          dataname = "ADSL",
          select = select_spec(
            label = "Select variable:",
            choices = variable_choices(ADSL, c("AGE", "BMRKR1")),
            selected = "AGE",
            multiple = FALSE,
            fixed = FALSE
          )
        )
      ),
      categorical_var = data_extract_spec(
        dataname = "ADSL",
        filter = filter_spec(
          vars = vars,
          choices = value_choices(ADSL, vars$selected),
          selected = value_choices(ADSL, vars$selected),
          multiple = TRUE
        )
      ),
      ggplot2_args = teal.widgets::ggplot2_args(labs = list(subtitle = "Plot generated by Outliers Module"))
    )
  )
)
shinyApp(app$ui, app$server)

sessionInfo()

No response

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct.

Contribution Guidelines

• I agree to follow this project's Contribution Guidelines.

Security Policy

• I agree to follow this project's Security Policy.

[Polkas]

This looks to be some edge case of the teal@8adc87e3 (full input cycle).
As we decided we should revert the commit, "revert if any problem arise".

Last thing to check is if the code which cause it is improper under the full input cycle. Then we do not want to revert pointed commit.

[Polkas]

So I find out the there is some reactivity from FilteredData, which cases the modules to be CREATED MANY
TIMES from scratch. The fIlter_spec shows us a side effect of it, the filter was reinitialized each time.
We could play here with isolate, still out primary decision was to revert it in such case.

I created a PR #677