remove FILTERED

[nikolas-burkoff]

Part of insightsengineering/teal.slice#76

Note:

The merge vignettes now work but I get the following warnings:

EDIT: Warning does not seem reproducible

See insightsengineering/teal.slice#77

[github-actions]

Unit Tests Summary

    1 files    24 suites   58s ⏱️
192 tests 191 ✔️ 1 💤 0 ❌
667 runs  666 ✔️ 1 💤 0 ❌

Results for commit 979f860.

♻️ This comment has been updated with latest results.

[gogonzo]

This change is because we make calls using c(...) instead of call("c", c(...)). Specifically here (below) where we call pivot_longer with cols = c(x, y , z) instead of cols = quote(c(x, y, z)). It's not something we need to be worried about because eval understands that.

  pivot_longer_call <- as.call(list(
    quote(tidyr::pivot_longer),
    cols = if (length(pl_cols)) pl_cols else quote(tidyselect::everything()),
    names_to = "MEASURE",
    values_to = "VALUE"
  ))  

Here is what I mean

r$> call("a", list(x = c(1, 2)))[[2]]
# $x
# [1] 1 2

r$> quote(a(x = c(1, 2)))[[2]]
# c(1, 2)

[nikolas-burkoff]

thanks for sorting this

[github-actions]

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ---------------------------------------------------------------------
R/all_choices.R                       1       0  100.00%
R/call_utils.R                      156     124  20.51%   14-23, 64, 66, 68, 107-431
R/check_selector.R                   31       0  100.00%
R/choices_labeled.R                 202      61  69.80%   60, 71, 76, 87, 103, 221-225, 229-234, 264-277, 390-391, 393, 425-473
R/choices_selected.R                 81      11  86.42%   201-229, 260
R/column_functions.R                  3       3  0.00%    13-16
R/data_extract_datanames.R           32       8  75.00%   9-13, 64-66
R/data_extract_filter_module.R       92      11  88.04%   75-82, 84, 87-88, 141
R/data_extract_module.R             247      61  75.30%   3, 121, 126, 143, 146-151, 153, 172-175, 203-249, 446, 451, 482, 585
R/data_extract_read_module.R        122      13  89.34%   28, 32-35, 102-107, 116, 133
R/data_extract_select_module.R       32      18  43.75%   31-48
R/data_extract_single_module.R       53       2  96.23%   29, 42
R/data_extract_spec.R                32       0  100.00%
R/data_merge_module.R                58      15  74.14%   101-118
R/filter_spec.R                     186       1  99.46%   373
R/format_data_extract.R              16       1  93.75%   49
R/get_dplyr_call.R                  299       0  100.00%
R/get_merge_call.R                  280      29  89.64%   28-34, 45, 206-215, 368, 384-396
R/include_css_js.R                    5       0  100.00%
R/input_checks.R                     11       2  81.82%   18-19
R/merge_data_utils.R                  2       0  100.00%
R/merge_datasets.R                  135       6  95.56%   72, 220-224
R/merge_expression_module.R          46       1  97.83%   148
R/resolve_delayed.R                  16       0  100.00%
R/resolve.R                         114      44  61.40%   229-312
R/select_spec.R                      49       8  83.67%   149, 213-220
R/utils.R                            15      11  26.67%   26-39
R/zzz.R                               2       2  0.00%    2-3
TOTAL                              2318     432  81.36%

Results for commit: ffcb708

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results