Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FILTERED #77

Merged
merged 8 commits into from
Jul 26, 2022
Merged

Remove FILTERED #77

merged 8 commits into from
Jul 26, 2022

Conversation

nikolas-burkoff
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff commented Jul 21, 2022

Closes #76

Also have:

Should we have a warning in teal.code?

Test with examples in vignettes and also with these apps

library(teal)
library(scda)

ADSL <- synthetic_cdisc_data("latest")$adsl
ADAE <- synthetic_cdisc_data("latest")$adae

app <- init(
  data = cdisc_data(
    cdisc_dataset("ADSL", ADSL, code = "ADSL <- synthetic_cdisc_data(\"latest\")$adsl"),
    cdisc_dataset("ADAE", ADAE, code = "ADAE <- synthetic_cdisc_data(\"latest\")$adae")
  ),
  modules = modules(teal:::filter_calls_module())
)

shinyApp(app$ui, app$server)


utils::data(miniACC, package = "MultiAssayExperiment")

app <- init(
  data = teal_data(
    dataset("iris", iris),
    dataset("mtcars", mtcars),
    dataset("miniacc", miniACC)
  ),
  modules = modules(teal:::filter_calls_module())
)

shinyApp(app$ui, app$server)

@nikolas-burkoff nikolas-burkoff changed the title Remove filtered Remove FILTERED Jul 21, 2022
@nikolas-burkoff nikolas-burkoff requested a review from gogonzo July 21, 2022 15:15
@gogonzo gogonzo self-assigned this Jul 22, 2022
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything here to fix except these minor comments.

R/CDISCFilteredData.R Outdated Show resolved Hide resolved
R/CDISCFilteredData.R Outdated Show resolved Hide resolved
@nikolas-burkoff nikolas-burkoff marked this pull request as ready for review July 22, 2022 08:10
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/call_utils.R                  156       4  97.44%   142-145
R/CDISCFilteredData.R           152      28  81.58%   92, 115, 124, 128, 142-151, 253-260, 278-281, 287, 352-355
R/choices_labeled.R              49      14  71.43%   19, 30, 35, 45-50, 62, 66-70
R/eval_expr_with_msg.R           16       6  62.50%   8-13
R/filter_panel_api.R             10       0  100.00%
R/filtered_data_wrappers.R       17      17  0.00%    134-169
R/FilteredData.R                417     290  30.46%   131, 215-219, 261-275, 316-330, 583-949, 973
R/FilteredDataset.R             252      84  66.67%   100, 187, 283, 322-362, 431-437, 478-488, 657-699
R/FilterState.R                1362     718  47.28%   160, 353-354, 451, 636-650, 712-762, 903-930, 1068-1177, 1202-1208, 1382-1542, 1666-1671, 1675-1681, 1694, 1698, 1830-1947, 2004-2010, 2023, 2155-2272, 2300-2306, 2319, 2405-2407, 2472-2633, 2662-2668, 2682
R/FilterStates.R               1413     591  58.17%   101, 119, 223, 302, 381, 432-618, 632-633, 751-787, 942-951, 1008, 1074, 1115, 1176-1181, 1316-1437, 1452, 1486, 1554-1559, 1579-1585, 1592-1597, 1604-1605, 1607, 1768-1777, 1810-1817, 1825-1832, 1860-2029, 2073, 2092-2098, 2105-2110, 2118-2119, 2121, 2169-2170, 2251-2369, 2416, 2449, 2470
R/include_css_js.R                5       5  0.00%    12-16
R/init_filitered_data.R          62       0  100.00%
R/MAEFilteredDataset.R          215      59  72.56%   25, 126, 258-334
R/Queue.R                        50      23  54.00%   22, 40-72, 96-113, 154
R/resolve_state.R                23       0  100.00%
R/utils.R                        72      13  81.94%   115-121, 133-138
R/variable_types.R               48      33  31.25%   42-47, 57, 70-105
R/zzz.R                           6       6  0.00%    3-11
TOTAL                          4325    1891  56.28%

Results for commit: f1fde36

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022

Unit Tests Summary

    1 files    29 suites   19s ⏱️
422 tests 422 ✔️ 0 💤 0
728 runs  728 ✔️ 0 💤 0

Results for commit 4c1b45a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good here.
No _FILTERED in whole insightsengineering. Apps working correctly

@nikolas-burkoff nikolas-burkoff merged commit 44b4ffc into main Jul 26, 2022
@nikolas-burkoff nikolas-burkoff deleted the 76_remove_filtered@main branch July 26, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change returned filter panel code to avoid _FILTERED suffix
2 participants