Fix false-positive deployment status #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedhav
force-pushed
the
69-fix-false-positive-icon
branch
from
7b23d8c to
8f4931b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69 #68 and #67
And remove unused assets from the demo apps as we've moved to a remote logo path
The fix for the cypress tests to work (#67) was to move the JS dependency lock files inside the
testsdirectory instead of the dedicatedjsdirectory as it was before.The deployment failure issues (#68) were caused by a new dependency added to some package in the
renv.lockfile and once we update the renv.lock file with the new package dependency it started to work fine.