Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filling NA group values for "overall" calculations during shuffle_ard() #306

Merged
merged 9 commits into from
Aug 30, 2024

Conversation

bzkrouse
Copy link
Collaborator

@bzkrouse bzkrouse commented Aug 29, 2024

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'
Closes #235


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Unit Tests Summary

  1 files  112 suites   33s ⏱️
109 tests 109 ✅ 0 💤 0 ❌
329 runs  329 ✅ 0 💤 0 ❌

Results for commit 143ed40.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
selectors 💚 $1.25$ $-1.24$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
add_calculated_row 💚 $1.25$ $-1.13$ add_calculated_row_x_
ard_categorical 💚 $8.97$ $-1.08$ ard_categorical_univariate
ard_hierarchical 💚 $9.47$ $-1.64$ ard_hierarchical_works_without_by_variables
selectors 💚 $1.25$ $-1.24$ selectors_work

Results for commit 9675262

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 29, 2024

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -----------------------------------
R/add_calculated_row.R            46       0  100.00%
R/apply_fmt_fn.R                  98      24  75.51%   45-52, 118-125, 207-214
R/ard_attributes.R                35       1  97.14%   56
R/ard_categorical.R              348      21  93.97%   233, 390-394, 401-402, 563-578, 612
R/ard_complex.R                   36       1  97.22%   83
R/ard_continuous.R               176       4  97.73%   118, 200-201, 299
R/ard_dichotomous.R               80       7  91.25%   62, 150-155
R/ard_hierarchical.R              83       0  100.00%
R/ard_missing.R                   58       1  98.28%   50
R/ard_stack.R                     84       7  91.67%   107, 186-191
R/ard_total_n.R                   10       0  100.00%
R/as_card.R                        5       0  100.00%
R/as_nested_list.R                41       0  100.00%
R/bind_ard.R                      47      18  61.70%   74-85, 87-93
R/check_ard_structure.R           39       6  84.62%   31, 55-59
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            16       1  93.75%   75
R/nest_for_ard.R                  71       1  98.59%   60
R/print_ard_conditions.R          75       1  98.67%   175
R/print.R                         72       0  100.00%
R/process_selectors.R            126       1  99.21%   337
R/replace_null_statistic.R        11       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     19       0  100.00%
R/shift_ard_columns.R             77      13  83.12%   61, 69, 144-147, 150-156
R/shuffle_ard.R                  126       0  100.00%
R/summary_functions.R             25       1  96.00%   59
R/tidy_ard_order.R                25       0  100.00%
R/tidy_as_ard.R                   39      11  71.79%   88-98
R/utils.R                         24       0  100.00%
TOTAL                           1929     119  93.83%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  --------
R/shuffle_ard.R      +24       0  +100.00%
TOTAL                +24       0  +0.08%

Results for commit: 143ed40

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@bzkrouse bzkrouse requested a review from ddsjoberg August 29, 2024 19:45
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function looks good to me. Just a couple of small changes requested. Thanks!

R/cards-package.R Outdated Show resolved Hide resolved
tests/testthat/_snaps/shuffle_ard.md Show resolved Hide resolved
@bzkrouse bzkrouse requested a review from ddsjoberg August 30, 2024 15:01
@ddsjoberg ddsjoberg merged commit 35e1698 into main Aug 30, 2024
35 checks passed
@ddsjoberg ddsjoberg deleted the shuffle-overall-fill branch August 30, 2024 17:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants