Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate overall categories for stack w/ overall and shuffle #235

Closed
wants to merge 1 commit into from

Conversation

bzkrouse
Copy link
Collaborator

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'
Resolves #234


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@bzkrouse bzkrouse requested a review from ddsjoberg April 25, 2024 18:07
Copy link
Contributor

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -------------------------------
R/apply_fmt_fn.R                  83      16  80.72%   97-104, 186-193
R/ard_attributes.R                29       0  100.00%
R/ard_categorical.R              347      17  95.10%   112, 212, 372-373, 529-544, 578
R/ard_complex.R                   33       0  100.00%
R/ard_continuous.R               175       4  97.71%   106, 188-189, 287
R/ard_dichotomous.R               66       2  96.97%   50, 136
R/ard_hierarchical.R              81       0  100.00%
R/ard_missing.R                   17       0  100.00%
R/ard_stack.R                     55       0  100.00%
R/as_nested_list.R                41       0  100.00%
R/bind_ard.R                      22       3  86.36%   51-53
R/check_ard_structure.R           27       1  96.30%   26
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       0  100.00%
R/get_ard_statistics.R            16       1  93.75%   75
R/nest_for_ard.R                  70       1  98.57%   56
R/print_ard_conditions.R          75      66  12.00%   61-177
R/print.R                         72       0  100.00%
R/process_selectors.R            114       0  100.00%
R/replace_null_statistic.R        11       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     14       0  100.00%
R/shuffle_ard.R                  132       1  99.24%   267
R/summary_functions.R             58       1  98.28%   91
R/tidy_ard_order.R                25       0  100.00%
R/tidy_as_ard.R                   39      11  71.79%   88-98
R/utils.R                         24       0  100.00%
TOTAL                           1663     124  92.54%

Diff against main

Filename         Stmts    Miss  Cover
-------------  -------  ------  --------
R/ard_stack.R       +4       0  +100.00%
TOTAL               +4       0  +0.02%

Results for commit: cbd9859

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files   81 suites   13s ⏱️
 79 tests  50 ✅ 29 💤 0 ❌
166 runs  123 ✅ 43 💤 0 ❌

Results for commit cbd9859.

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
selectors 💚 $1.16$ $-1.09$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_stack 👶 $+0.00$ ard_stack_.shuffle_.overall
selectors 💚 $1.17$ $-1.09$ selectors_work

Results for commit db3193d

♻️ This comment has been updated with latest results.

@ddsjoberg ddsjoberg closed this Jun 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
ddsjoberg added a commit that referenced this pull request Aug 30, 2024
…d()` (#306)

**What changes are proposed in this pull request?**
* Style this entry in a way that can be copied directly into `NEWS.md`.
(#<issue number>, @<username>)

Provide more detail here as needed.

**Reference GitHub issue associated with pull request.** _e.g., 'closes
#<issue number>'_
Closes #235 


--------------------------------------------------------------------------------

Pre-review Checklist (if item does not apply, mark is as complete)
- [x] **All** GitHub Action workflows pass with a ✅
- [x] PR branch has pulled the most recent updates from master branch:
`usethis::pr_merge_main()`
- [x] If a bug was fixed, a unit test was added.
- [x] Code coverage is suitable for any new functions/features
(generally, 100% coverage for new code): `devtools::test_coverage()`
- [x] Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

- [x] If a bug was fixed, a unit test was added.
- [x] Run `pkgdown::build_site()`. Check the R console for errors, and
review the rendered website.
- [x] Code coverage is suitable for any new functions/features:
`devtools::test_coverage()`

When the branch is ready to be merged:
- [x] Update `NEWS.md` with the changes from this pull request under the
heading "`# cards (development version)`". If there is an issue
associated with the pull request, reference it in parentheses at the end
update (see `NEWS.md` for examples).
- [x] **All** GitHub Action workflows pass with a ✅
- [x] Approve Pull Request
- [x] Merge the PR. Please use "Squash and merge" or "Rebase and merge".

---------

Signed-off-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
Co-authored-by: Daniel Sjoberg <danield.sjoberg@gmail.com>
@ddsjoberg ddsjoberg deleted the ard_stack-overall-cats branch October 2, 2024 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate "overall" categories for ard_stack(..., .overall = TRUE, .shuffle = TRUE)
2 participants