Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using rlang::error_call() to get calling function name for messaging #134

Merged
merged 15 commits into from
Jan 27, 2024

Conversation

ddsjoberg
Copy link
Collaborator

@ddsjoberg ddsjoberg commented Jan 26, 2024

What changes are proposed in this pull request?

  • using rlang::error_call() to get calling function name for messaging

Reference GitHub issue associated with pull request. e.g., 'closes #1'
closes #128
closes #133


Reviewer Checklist (if item does not apply, mark is as complete)

  • Ensure all package dependencies are installed: devtools::install_dev_deps()
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@ddsjoberg ddsjoberg requested a review from bzkrouse January 26, 2024 21:23
Copy link
Contributor

github-actions bot commented Jan 27, 2024

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  ----------------------
R/apply_statistic_fmt_fn.R        58       2  96.55%   90, 160
R/ard_attributes.R                28       0  100.00%
R/ard_categorical.R              304      15  95.07%   100, 184, 443-458, 486
R/ard_comparison.R               163       0  100.00%
R/ard_complex.R                   33       0  100.00%
R/ard_continuous.R               176       4  97.73%   96, 178-179, 245
R/ard_dichotomous.R               68       8  88.24%   119-122, 124-127
R/ard_hierarchical.R              72       0  100.00%
R/ard_missing.R                   16       0  100.00%
R/ard_regression.R                51       0  100.00%
R/as_nested_list.R                41       1  97.56%   18
R/bind_ard.R                      21       1  95.24%   49
R/check_ard_structure.R           26       1  96.15%   23
R/check_pkg_installed.R          100       1  99.00%   154
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       18       3  83.33%   54-57
R/get_ard_statistics.R            15       1  93.33%   50
R/nest_for_ard.R                  69       1  98.55%   55
R/print_ard_conditions.R          72      65  9.72%    52-140
R/print.R                         69      10  85.51%   78, 87-95
R/process_selectors.R            103       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     12       0  100.00%
R/shuffle_ard.R                  127       7  94.49%   161, 209, 257-261
R/standalone-checks.R             16       2  87.50%   51, 70
R/standalone-stringr.R            11       0  100.00%
R/summary_functions.R             45       0  100.00%
R/tidy_ard_order.R                24       0  100.00%
R/tidy_as_ard.R                   38       0  100.00%
R/utils.R                         15       0  100.00%
TOTAL                           1810     122  93.26%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  --------
R/apply_statistic_fmt_fn.R       +3       0  +0.19%
R/ard_categorical.R             +14      +2  -0.45%
R/ard_comparison.R              +10       0  +100.00%
R/ard_continuous.R              +10       0  +0.14%
R/ard_dichotomous.R              +6       0  +1.14%
R/ard_hierarchical.R             +2       0  +100.00%
R/ard_regression.R               +7       0  +100.00%
R/check_ard_structure.R          +5       0  +0.92%
R/check_pkg_installed.R          +2       0  +0.02%
R/nest_for_ard.R                 +2       0  +0.04%
R/print_ard_conditions.R         +9      +8  +0.20%
R/print.R                        +6       0  +1.38%
R/process_selectors.R           +12       0  +100.00%
R/shuffle_ard.R                 +10      +1  -0.38%
R/standalone-checks.R            +3       0  +2.88%
R/summary_functions.R            +5       0  +100.00%
R/tidy_ard_order.R               +4       0  +100.00%
R/tidy_as_ard.R                  +4       0  +100.00%
R/utils.R                        +1       0  +100.00%
TOTAL                          +115     +11  -0.19%

Results for commit: e5df517

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jan 27, 2024

Unit Tests Summary

  1 files  63 suites   9s ⏱️
 61 tests 33 ✅ 28 💤 0 ❌
126 runs  85 ✅ 41 💤 0 ❌

Results for commit e5df517.

♻️ This comment has been updated with latest results.

@ddsjoberg ddsjoberg merged commit 23acbee into main Jan 27, 2024
28 checks passed
@ddsjoberg ddsjoberg deleted the adding-rlang-error_call branch January 27, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use consistent env and call argument names Get the calling function from passed environment
1 participant