Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent env and call argument names #133

Closed
ddsjoberg opened this issue Jan 26, 2024 · 0 comments · Fixed by #134
Closed

Use consistent env and call argument names #133

ddsjoberg opened this issue Jan 26, 2024 · 0 comments · Fixed by #134
Assignees
@ddsjoberg
Milestone
v0.1.0

Comments

@ddsjoberg
Copy link
Collaborator

I think I am mixing env and call argument names that are being used for the same thing.

Similarly, the default value is a mix of parent.frame() and rlang::caller_env()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddsjoberg ddsjoberg

Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

using rlang::error_call() to get calling function name for messaging insightsengineering/cards
1 participant
@ddsjoberg