-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: signable builder services compute full protocol message #1942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have some questions about responsabilities of the services
7fb6683
to
d445ce7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
mithril-common/src/signable_builder/signable_builder_service.rs
Outdated
Show resolved
Hide resolved
Which is responsible for computing the seed message that will be used by signable builders to compute their respective protocol messages.
…ableBuilder trait
…gregator integration test
…gner integration test
Rollback to the original trait.
…lues And let the responsibility of using it in the signable builder service.
…eedBuilder' in aggregator
…uilder' in signer
…sub-module of services in aggregator
…sub-module of services in signer
- 'mithril-aggregator' from '0.5.67' to '0.5.68' - 'mithril-common' from '0.4.57' to '0.4.58' - 'mithril-signer' from '0.2.186' to '0.2.187'.
ab51421
to
71fef49
Compare
Content
This PR includes a refactoring of the signable builder service so that it computes the next aggregate verification key part of the protocol message instead of delegating this responsibility to the state machines runners in signer and aggregator.
A new
SignableSeedBuilder
trait has been created which is responsible for computing part of the protocol message by theSignableBuilder
service to enrich it.Pre-submit checklist
Issue(s)
Closes #1941