Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor signable builder services to compute full protocol message in signer/aggregator #1941

Closed
2 tasks done
jpraynaud opened this issue Sep 20, 2024 · 0 comments · Fixed by #1942
Closed
2 tasks done

Refactor signable builder services to compute full protocol message in signer/aggregator #1941

jpraynaud opened this issue Sep 20, 2024 · 0 comments · Fixed by #1942
Assignees
@jpraynaud
Labels
refactoring 🛠️ Code refactoring and enhancements

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Sep 20, 2024 •
edited
Loading

Why

We have some duplicated code when the signature of the aggregate verification key is appended to the signed protocol message. Also this operation is done in the runners of the nodes whereas it should be the responsibility of the signable builder services in the signer and aggregator.

What

Make the signable builder compute the full protocol message on its own in the signer and aggregator

How

  • Refactor the signable builder service to compute the full protocol message on its own in the aggregator
  • Refactor the signable builder service to compute the full protocol message on its own in the signer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpraynaud jpraynaud

Labels
refactoring 🛠️ Code refactoring and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: signable builder services compute full protocol message input-output-hk/mithril
1 participant
@jpraynaud