-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensemble/1825/cleanup immutable file in cardano transation #1838
Merged
sfauvel
merged 9 commits into
main
from
ensemble/1825/cleanup_immutable_file_in_cardano_transation
Jul 17, 2024
Merged
Ensemble/1825/cleanup immutable file in cardano transation #1838
sfauvel
merged 9 commits into
main
from
ensemble/1825/cleanup_immutable_file_in_cardano_transation
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfauvel
temporarily deployed
to
testing-sanchonet
July 17, 2024 13:19
— with
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
July 17, 2024 13:31
— with
GitHub Actions
Inactive
jpraynaud
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Alenar
approved these changes
Jul 17, 2024
Remove reference to rescan_offset and immutable
dlachaume
approved these changes
Jul 17, 2024
* Mithril-signer: 0.2.166 => 0.2.167 * Mithril-persistence: 0.2.17 => 0.2.18 * Mithril-common: 0.4.31 => 0.4.32 * Mithril-aggregator: 0.5.44 => 0.5.45
sfauvel
force-pushed
the
ensemble/1825/cleanup_immutable_file_in_cardano_transation
branch
from
July 17, 2024 15:02
fbdb299
to
ca91a6d
Compare
sfauvel
temporarily deployed
to
testing-sanchonet
July 17, 2024 15:09
— with
GitHub Actions
Inactive
sfauvel
deleted the
ensemble/1825/cleanup_immutable_file_in_cardano_transation
branch
July 17, 2024 15:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR removes all references to
immutable_file
in Cardano Transaction signed entity processing.immutable_file_number
column fromcardano_tx
.immutable_file_number
field from typeentities::CardanoTransaction
andScannedBlock
.ImmutableBlockStreamer
andCardanoImmutableBlockScanner
.BlockScanner
trait by removing thedirpath
parameter of the scan method. That allow to remove it fromCardanoTransactionsImporter
service.Pre-submit checklist
Issue(s)
Closes #1825